Skip to content

Fix SwitchRow subtitles#45

Merged
bcylin merged 4 commits into
bcylin:developfrom
dnicolson:fix-switchrow-subtitles
May 23, 2020
Merged

Fix SwitchRow subtitles#45
bcylin merged 4 commits into
bcylin:developfrom
dnicolson:fix-switchrow-subtitles

Conversation

@dnicolson
Copy link
Copy Markdown
Contributor

This pull request enables SwitchRow subtitles, previously the detailText value would not be displayed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2020

Codecov Report

Merging #45 into develop will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
- Coverage    95.10%   94.87%   -0.23%     
===========================================
  Files           14       14              
  Lines          347      332      -15     
===========================================
- Hits           330      315      -15     
  Misses          17       17              
Impacted Files Coverage Δ
Source/Rows/SwitchRow.swift 100.00% <100.00%> (ø)
Source/QuickTableViewController.swift 89.18% <0.00%> (-1.06%) ⬇️
Source/Model/RadioSection.swift 94.73% <0.00%> (-0.62%) ⬇️
Source/Protocol/Reusable.swift 100.00% <0.00%> (ø)
Source/Protocol/Configurable.swift 100.00% <0.00%> (ø)

Comment thread Source/Rows/SwitchRow.swift Outdated
Comment thread Source/Rows/SwitchRow.swift Outdated
dnicolson and others added 3 commits May 22, 2020 21:54
Co-authored-by: Ben <b.cylin@gmail.com>
Co-authored-by: Ben <b.cylin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants